Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump staticcheck to 2022.1 with Go 1.18 support #457

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

Didainius
Copy link
Collaborator

Github actions introduced Go 1.18 environment and our used staticcheck version does not support it. This PR bumps staticcheck to 2022.1 with Go 1.18 support.

This new staticheck version discovered one error to fix:

api.go:236:5: should omit nil check; len() for net/http.Header is defined as zero (S1009)

This PR also patches it.

Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius self-assigned this Apr 1, 2022
@Didainius Didainius marked this pull request as ready for review April 1, 2022 17:37
@Didainius Didainius removed the request for review from dataclouder April 1, 2022 17:37
@Didainius Didainius merged commit 877dfc8 into vmware:main Apr 4, 2022
@Didainius Didainius deleted the githubactiongo1_18 branch April 4, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants